gdlauncher-carbon: init at 2.0.20

[huantianad]

Description of changes

Package request issue: #269067

Packaged by extracting app.asar as well as binary blob from provided AppImage, and wrapping with our own electron.

Haven't done much testing, so putting this as a draft for now, just to get some eyes on this. I also haven't added any of the libraries that MC itself needs. I wonder if we could borrow some code from prismlauncher.

If wanted, we could also provide a derivation built from source; however as mentioned in the request issue thread, it won't have all the features as the pre-built version comes with an API key for their own servers.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[huantianad]

@PassiveLemon You might be interested!

[huantianad]

I'm not 100% sure this is needed, but I'm assuming that app does depend on xdg-utils to open up browser pages, including for signin. Would have to test on a system without it though.

[PassiveLemon]

I'll check it out later, looks promising though

[PassiveLemon]

Upon running GDL, it returns: cannot execute /nix/store/lcvhr3s23c2i53ackxh8c39lggcfs0mq-gdlauncher-carbon-2.0.1/share/gdlauncher-carbon/resources/binaries/core_module: You are trying to run an unpatched binary on nixos, but you have not configured NIX_LD or NIX_LD_x86_64-linux. See https://github.com/Mic92/nix-ld for more details
The icon is also not used.
Seems like something is up. My personal package works fine however.

[huantianad]

Wups I've been testing this with mix-ld 🤦

Also wdym about the icon?

[PassiveLemon]

Also wdym about the icon?

The icon is simply not in my app launcher.

[huantianad]

Man I thought I fixed that with my recent force pushes, can you check to see if the icons were installed in the right folders?

[PassiveLemon]

I see icons in both $out/share/icons/hicolor/128x128/apps/gdlauncher-carbon.png and 512x512 and I can open both in feh so I'm not really sure what the issue is there.

In my package, the icon was installed in $out/share/pixmaps/gdlauncher-carbon.png so I added a line to install in there in the derivation and it does find the icon after that.

[huantianad]

That's strange, pixmap shouldn't be the place to put these icons tho. Maybe I should also add a 48x48 and 96x96 size?

[PassiveLemon]

Nvm, it actually does work at those sizes. Didn't realize I had to restart my WM for the icon to update. Guess there was some caching, sorry for the concern lol

[huantianad]

I've fixed the core binary issue as well as added some of the libraries from prismlauncher. Not sure if all of them are necessary, or if the ones I skipped are also needed. Perhaps @Scrumplex can give some insight here.

[Scrumplex]

glfw and openal might not be needed here, as Prism Launcher has a feature to override the versions shipped by LWJGL, while I assume GDLauncher does not

[PassiveLemon]

Tested the package, it works

[huantianad]

glfw and openal might not be needed here, as Prism Launcher has a feature to override the versions shipped by LWJGL, while I assume GDLauncher does not

Makes sense, I've mentioned the feature to the dev and they seem interested in possibly adding in the future. For now, removing.

[FliegendeWurst]

I think this is done automatically by all relevant icon users?

[huantianad]

Perhaps I can try again; last time I checked, it didn't seem to work on KDE Plasma.

[FliegendeWurst]

Use addDriverRunPath instead, see #275241

[Pandapip1]

Currently failing with:

       error: evaluation aborted with the following error message: 'lib.customisation.callPackageWith: Function called without required argument "addOpenGLRunpath" at /ofborg/checkout/1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-3/pkgs/by-name/gd/gdlauncher-carbon/package.nix:16'

[huantianad]

By the way, if someone could help co-maintain this package, would be appreciated, as I don't use it myself at all.

resolved

[TsubakiDev]

I have a lot of free time, can I apply to be a co-maintainer of this package?

[FliegendeWurst]

I have a lot of free time, can I apply to be a co-maintainer of this package?

Yes, certainly :)

Since you are not listed in maintainer-list.nix yet, huantianad can add your details there and then add you to meta.maintainers of this package.

[TsubakiDev]

Thanks (⁠｡⁠･⁠ω⁠･⁠｡⁠)⁠ﾉ⁠♡ I'm happy to be the maintainer of this package (⁠◍⁠•⁠ᴗ⁠•⁠◍⁠)⁠❤

…

________________________________ 发件人: Arne Keller ***@***.***> 发送时间: 2024年12月8日 20:32 收件人: NixOS/nixpkgs ***@***.***> 抄送: Daniel Wang ***@***.***>; Comment ***@***.***> 主题: Re: [NixOS/nixpkgs] gdlauncher-carbon: init at 2.0.20 (PR #297096) I have a lot of free time, can I apply to be a co-maintainer of this package? Yes, certainly :) Since you are not listed in maintainer-list.nix yet, huantianad can add your details there and then add you to meta.maintainers of this package. — Reply to this email directly, view it on GitHub<#297096 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A7VESAI6QC245EUASBYEGGL2EQ34TAVCNFSM6AAAAABR6FERQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRVG42DCMZSGE>. You are receiving this because you commented.Message ID: ***@***.***>

[huantianad]

Not sure what the procedure for this is, @TsubakiDev can you let me know what you want your entry in https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix to look like? Comment at the start has instructions.

I'll make a commit with that myself, or I suppose if you'd like you could make the commit in your own fork and I'll cherry-pick it into this PR branch (though that's probably unnecessarily complex).

[TsubakiDev]

Not sure what the procedure for this is, @TsubakiDev can you let me know what you want your entry in https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix to look like? Comment at the start has instructions.

I'll make a commit with that myself, or I suppose if you'd like you could make the commit in your own fork and I'll cherry-pick it into this PR branch (though that's probably unnecessarily complex).

TsubakiDev = {
    email = i@tsubakidev.cc";
    github = "TsubakiDev";
    githubId = 132794625;
    name = "Daniel Wang";
  };

This is my entry at maintainer-list.nix.