Skip to content

haskellPackages.cpython: unbreak and add @sheepforce as maintainer#296926

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
sheepforce:haskell-cpython-fixes
Mar 18, 2024
Merged

haskellPackages.cpython: unbreak and add @sheepforce as maintainer#296926
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
sheepforce:haskell-cpython-fixes

Conversation

@sheepforce
Copy link
Member

@sheepforce sheepforce commented Mar 18, 2024

Description of changes

Unbreaks the cpython package after upstream compatibility with Python >= 3.8 was enabled zsedem/haskell-cpython#21

I've removed the entry from broken.yaml but was entirely sure if another step is required :)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Mar 18, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 18, 2024
@maralorn
Copy link
Member

Nice, thank you.

@maralorn maralorn merged commit fc224fa into NixOS:haskell-updates Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants