Conversation
Putting everything that has lib/ directory is redundant and bloats environment for projects with many dependencies.
ofborg
bot
added
10.rebuild-darwin: 101-500
| # will contain "include/SDL/" and "lib/" directories. | ||
| # | ||
| # However the SDL_LIB_PATH is consumed by SDL itself and serves to locate | ||
| # libraries like SDL2_mixer, SDL2_image, etc which are not split-package |
There was a problem hiding this comment.
sdl2-mixer has out and dev however sdl-mixer doesn't
and there's no sdl-* which have split outputs fd --type d 'sdl_' pkgs/development/libraries | xargs -I {} cat "{}/default.nix" | grep outputs
There was a problem hiding this comment.
Maybe the lib file names could be matched for sdl? that could work with split outputs
There was a problem hiding this comment.
I think we're accidentally fine - SDL_PATH is only used by the SDL package. For SDL2 there's SDL2_PATH and different setup hook, still employing similar structure and probably susceptible to sdl2-mixer having split outputs: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/SDL2/setup-hook.sh.
Maybe the lib file names could be matched for sdl? that could work with split outputs
Do you mean that shell in setup-hook.sh would somehow analyse its argument to determine whether we're looking at an sdl components package?
2 participants
This is a resurrection of #254465 which got accidentally closed without merging relevant changes.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.