{edencommon,fb303,fbthrift,fizz,folly,mvfst,wangle,watchman}: 2024.01.22.00 -> 2024.03.11.00

[sdht0]

Description of changes

Updating to the latest releases. Many of these need to be updated in tandem as there are interdependent changes without which the builds fail.

• Successfully built all changed packages
• Tested building some random dependent packages: fava, python3Packages.types-aiobotocore-opensearchserverless

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[risicle]

On macos 12 x86_64, folly fails to build:

In file included from /tmp/nix-build-folly-2024.03.11.00.drv-0/source/folly/logging/example/lib.cpp:17:
In file included from /tmp/nix-build-folly-2024.03.11.00.drv-0/source/folly/logging/example/lib.h:21:
In file included from /tmp/nix-build-folly-2024.03.11.00.drv-0/source/folly/logging/xlog.h:26:
In file included from /tmp/nix-build-folly-2024.03.11.00.drv-0/source/folly/logging/LoggerDB.h:29:
In file included from /tmp/nix-build-folly-2024.03.11.00.drv-0/source/folly/detail/StaticSingletonManager.h:27:
In file included from /tmp/nix-build-folly-2024.03.11.00.drv-0/source/folly/lang/Thunk.h:22:
/tmp/nix-build-folly-2024.03.11.00.drv-0/source/folly/lang/New.h:66:12: error: no matching function for call to object of type 'const conditional_t<false, op_del_builtin_fn_, op_del_library_fn_>' (aka 'const folly::detail::op_del_library_fn_')
    return op_del_<Usual>(p, a...);
           ^~~~~~~~~~~~~~
/tmp/nix-build-folly-2024.03.11.00.drv-0/source/folly/lang/New.h:119:20: note: in instantiation of function template specialization 'folly::detail::do_op_del_sized_<false, std::align_val_t>' requested here
    return detail::do_op_del_sized_<detail::cpp_aligned_new_>(p, s, a);
                   ^
/tmp/nix-build-folly-2024.03.11.00.drv-0/source/folly/lang/New.h:52:1: note: candidate template ignored: substitution failure [with A = <void *const &, const std::align_val_t &>]
FOLLY_CREATE_QUAL_INVOKER(op_del_library_fn_, ::operator delete);
^
/tmp/nix-build-folly-2024.03.11.00.drv-0/source/folly/functional/Invoke.h:515:58: note: expanded from macro 'FOLLY_CREATE_QUAL_INVOKER'
    [[maybe_unused]] FOLLY_ERASE_HACK_GCC constexpr auto operator()(A&&... a) \

[risicle]

Awesome, all WFM now on macos 12 x86_64. Could you squash down the fixup commits so it's one commit per package and I'll approve?

[sdht0]

Done

[risicle]

Cherry-picked to staging-next for testing, build each updated package + folly.tests on nixos x86_64 & macos 12 x86_64 successfully.