virtualbox: pin jdk to openjdk17#295327
Merged
vcunat merged 1 commit intoNixOS:masterfrom Mar 12, 2024
Merged
Conversation
Member
Author
|
@ofborg build virtualbox virtualbox.passthru.tests |
Member
|
How do I make @ofborg build |
ofborg
bot
added
10.rebuild-darwin: 0
wegank
force-pushed
the
virtualbox-openjdk
branch
from
390053b to
51d879e
Compare
wegank
changed the title
Member
Author
|
Result of 1 package failed to build:
29 packages built:
|
Member
|
I don't know anything about this, but why 17 in particular? I believe it used 19 on the last successful build (before PR #273811). |
Member
|
Aah, I guess it's because 17 is LTS (also 21) but 19 is not and even looks EOL already. |
Member
|
virtualbox and ova build for me. Let's unblock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.