lua: actually fix longstanding bug in lua envHook causing relative module imports to stop working#295012
Merged
vcunat merged 1 commit intoNixOS:stagingfrom Mar 12, 2024
Merged
Conversation
…dule imports to stop working somehow, between all my testing, all the code review, and my code being copy-pasted into other people's PRs, noone noticed the glaring issue in the singular line of code i committed. there was a missing negation. this has now been fixed.
github-actions
bot
added
the
6.topic: lua
Contributor
Author
ofborg
bot
added
10.rebuild-darwin: 501+
teto
approved these changes
Mar 11, 2024
delroth
added
the
12.approvals: 1
Member
|
Looks OK at a glance. I also checked the packages reported previously. |
Member
|
It looks like this regressed again on staging-next somehow (2f73b69).
|
Contributor
Author
Member
|
Yes, reverting that PR fixed the regression for me. Anyway, it's discussed there. |
Member
|
alright, thanks. Sorry for the noise! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
somehow, between all my testing, all the code review, and my code being copy-pasted into other people's PRs, noone noticed the glaring issue in the singular line of code i committed.
there was a missing negation. this has now been fixed.
related: #289135 and the associated reversion
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.