fastqc: init at 0.12.1 #294891
Merged
fastqc: init at 0.12.1 #294891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
10.rebuild-darwin: 0
natsukium
reviewed
Mar 11, 2024
|
As mentioned before, this software comes with a gpl3plus license, but includes a precompiled JAVA library released with an asl20 license. |
leona-ya
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Can you also squash the commits touching the package (not the one in which you add your maintainer entry) in one commit fastqc: init at 0.12.1 (see https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions for details).
fastqc: remove trailing whitespaces fastqc: moved to by-name hierarchy Update pkgs/by-name/fa/fastqc/package.nix Co-authored-by: OTABI Tomoya <[email protected]> Update pkgs/by-name/fa/fastqc/package.nix Co-authored-by: OTABI Tomoya <[email protected]> Update pkgs/by-name/fa/fastqc/package.nix Co-authored-by: OTABI Tomoya <[email protected]> Update pkgs/by-name/fa/fastqc/package.nix Co-authored-by: OTABI Tomoya <[email protected]> Update pkgs/by-name/fa/fastqc/package.nix Co-authored-by: OTABI Tomoya <[email protected]> fastqc: suggested code changes applied fastqc: added testVersion fastqc: some corrections fastqc: remove with lib;
natsukium
reviewed
Mar 18, 2024
natsukium
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
New package called FastQC for the science/biology category. It's a DNA sequence quality checker written in JAVA. It can run on the command line or with its graphical interface.
https://www.bioinformatics.babraham.ac.uk/projects/fastqc/
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)