Skip to content

nixos/yubikey-agent: fix eval error#294771

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
flokli:yubikey-agent-eval
Mar 10, 2024
Merged

nixos/yubikey-agent: fix eval error#294771
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
flokli:yubikey-agent-eval

Conversation

@flokli
Copy link
Member

@flokli flokli commented Mar 10, 2024

This has been refactored in #133542, but this reference wasn't updated.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@flokli flokli mentioned this pull request Mar 10, 2024
11 tasks
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 10, 2024
This has been refactored in https://github.com/NixOS/nixpkgs/
pull/133542, but this reference wasn't updated.
@flokli flokli force-pushed the yubikey-agent-eval branch from 9e70c9f to b437b19 Compare March 10, 2024 17:08
@RaitoBezarius
Copy link
Member

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@RaitoBezarius merge not permitted:
nixos/modules/services/security/yubikey-agent.nix is not in pkgs/by-name/

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 10, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 10, 2024
@SuperSandro2000 SuperSandro2000 merged commit 88c9f04 into NixOS:master Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants