luaPackages: update on 2024-04-12#294057
Merged
teto merged 7 commits intoNixOS:stagingfrom Apr 13, 2024
Merged
Conversation
github-actions
bot
added
the
6.topic: lua
Contributor
Author
|
Result of 18 packages marked as broken and skipped:
53 packages failed to build:
1953 packages built:
|
Contributor
Author
|
Result of 18 packages marked as broken and skipped:
53 packages failed to build:
1950 packages built:
|
GaetanLepage
force-pushed
the
luarocks-packages-update
branch
2 times, most recently
from
4538bf6 to
024bb6d
Compare
ofborg
bot
added
10.rebuild-darwin: 501+
GaetanLepage
force-pushed
the
luarocks-packages-update
branch
from
024bb6d to
e80fc59
Compare
GaetanLepage
force-pushed
the
luarocks-packages-update
branch
from
e80fc59 to
6ecf62d
Compare
GaetanLepage
changed the title
Contributor
Author
|
|
Contributor
Author
|
Result of 18 packages marked as broken and skipped:
10 packages failed to build:
2026 packages built:
|
mrcjkb
suggested changes
Mar 31, 2024
Member
There was a problem hiding this comment.
Great to see more people joining in on maintaining this 😄
Normally, PRs with such a large amount of rebuilds should target the staging branch.
I don't know if that applies to luaPackages/vimPlugins too, though. @teto what do you think?
GaetanLepage
force-pushed
the
luarocks-packages-update
branch
from
6ecf62d to
056313c
Compare
Contributor
Author
GaetanLepage
changed the title
Contributor
Author
|
Result of 18 packages marked as broken and skipped:
2042 packages built:
|
mrcjkb
approved these changes
Mar 31, 2024
Contributor
Author
|
Result of 18 packages marked as broken and skipped:
2039 packages built:
|
Contributor
Author
|
Result of 21 packages marked as broken and skipped:
28 packages failed to build:
1973 packages built:
|
Contributor
Author
|
Result of 21 packages marked as broken and skipped:
31 packages failed to build:
1970 packages built:
|
wegank
added
12.approvals: 1
GaetanLepage
force-pushed
the
luarocks-packages-update
branch
from
056313c to
7635fdb
Compare
GaetanLepage
changed the title
GaetanLepage
force-pushed
the
luarocks-packages-update
branch
3 times, most recently
from
9d4c4a5 to
5cce49a
Compare
Contributor
Author
|
Result of 19 packages marked as broken and skipped:
2087 packages built:
|
Member
|
ofborg mentions: I tried a nixpkgs-review from a server which concluded the same as ofborg. If I try a I get the hash currently used but not liked by ofborg (luarocks-nix uses nix-prefetch-url under the hood so that makes sense). I tried nix-prefetch-url --unpack but once translated to sri ( |
13 tasks
Member
|
@ofborg build lua52Packages.dkjson.src lua52Packages.dkjson |
1 similar comment
Contributor
Author
|
@ofborg build lua52Packages.dkjson.src lua52Packages.dkjson |
vcunat
reviewed
Apr 10, 2024
Member
There was a problem hiding this comment.
Uh, are you sure about this part?
GaetanLepage
force-pushed
the
luarocks-packages-update
branch
from
3b40b23 to
f5d473e
Compare
GaetanLepage
force-pushed
the
luarocks-packages-update
branch
from
f5d473e to
1c8e4a0
Compare
GaetanLepage
changed the title
Contributor
Author
|
Result of 19 packages marked as broken and skipped:
5 packages failed to build:
2081 packages built:
|
Member
|
According to @GaetanLepage knot already breaks on staging so merging. Thanks for the huge work, I have a bunch of PR that I need to submit to add transitive lua dependencies support to neovim plugins and this will make regenerating the lua set a lot easier ! |
Member
|
Contributor
Author
Ok, I have definitely not noticed. Do you want me to address it on this branch ? |
Member
|
It's in |
poscat0x04
reviewed
Jun 1, 2024
Contributor
There was a problem hiding this comment.
You sure this would work? @GaetanLepage
Just removing the version bound doesn't seem like a good idea to me...
Contributor
Author
There was a problem hiding this comment.
Sorry, I have forgot to answer you. Is this still an issue ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Update the lua packages. Generated using the
luarocks-packages-updaterscript.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.