Skip to content

rework luajit and lua postPatch #293865

Closed
lolbinarycat wants to merge 2 commits intoNixOS:stagingfrom
lolbinarycat:lua-simple-patch
Closed

rework luajit and lua postPatch #293865
lolbinarycat wants to merge 2 commits intoNixOS:stagingfrom
lolbinarycat:lua-simple-patch

Conversation

@lolbinarycat
Copy link
Contributor

Description of changes

previously, we were completely overriding LUA_PATH_DEFAULT and LUA_CPATH_DEFAULT (even though luajit explictly says not to).

this caused several problems, such as #290721 and #293832

this PR changes simplifies how these variables are overridden, only changing PREFIX or LUA_ROOT

this will need much testing to see if it breaks anything in luaPackages

Things done

  • Built on platform(s)
    • x86_64-linux (NOTE: i tested nix-build before rebasing to staging)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. label Mar 6, 2024
@teto
Copy link
Member

teto commented Mar 6, 2024

please hold on a bit, Iam doing the same already in #286822 (comment), will push in a bit

@lolbinarycat lolbinarycat marked this pull request as draft March 6, 2024 22:42
@lolbinarycat
Copy link
Contributor Author

@teto i was under the impression that PR took the approach of modifying LUA_PATH_DEFAULT even more, instead of just making it use the defaults.

@lolbinarycat lolbinarycat marked this pull request as ready for review March 6, 2024 23:34
@lolbinarycat
Copy link
Contributor Author

if anyone is willing to run nixpkgs-review on this it would be greatly appreciated, the command is too much for my poor little laptop.

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 6, 2024
@lolbinarycat
Copy link
Contributor Author

closing in favor of #286822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants