rework luajit and lua postPatch #293865
Closed
lolbinarycat wants to merge 2 commits intoNixOS:stagingfrom
Closed
Conversation
Member
|
please hold on a bit, Iam doing the same already in #286822 (comment), will push in a bit |
Contributor
Author
|
@teto i was under the impression that PR took the approach of modifying LUA_PATH_DEFAULT even more, instead of just making it use the defaults. |
Contributor
Author
|
if anyone is willing to run nixpkgs-review on this it would be greatly appreciated, the command is too much for my poor little laptop. |
Contributor
Author
|
closing in favor of #286822 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
previously, we were completely overriding LUA_PATH_DEFAULT and LUA_CPATH_DEFAULT (even though luajit explictly says not to).
this caused several problems, such as #290721 and #293832
this PR changes simplifies how these variables are overridden, only changing PREFIX or LUA_ROOT
this will need much testing to see if it breaks anything in luaPackages
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.