Skip to content

pict-rs: Mark broken on darwin#293608

Merged
happysalada merged 1 commit intoNixOS:masterfrom
9999years:fix-pict-rs
Mar 6, 2024
Merged

pict-rs: Mark broken on darwin#293608
happysalada merged 1 commit intoNixOS:masterfrom
9999years:fix-pict-rs

Conversation

@9999years
Copy link
Contributor

@9999years 9999years commented Mar 5, 2024

Description of changes

Marks pict-rs as broken. It has a bunch of build failures.

Split off of #293560.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 5, 2024
@ofborg ofborg bot requested a review from happysalada March 5, 2024 23:43
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 5, 2024
@9999years 9999years changed the title pict-rs: Fix build pict-rs: Mark broken Mar 6, 2024
@eclairevoyant
Copy link
Contributor

Where are you seeing these build failures? Neither hydra nor a local build (x86_64-linux) seem to indicate such.

@9999years
Copy link
Contributor Author

aarch64-darwin.

@eclairevoyant
Copy link
Contributor

eclairevoyant commented Mar 6, 2024

Then meta.broken shouldn't be unconditonally set to true, but only marked broken on that arch.

A lot of build failures when testing:

```
pict-rs> Executing cargoCheckHook
pict-rs> ++ cargo test -j 20 --profile release --target aarch64-apple-darwin --frozen -- --test-threads=20
pict-rs>    Compiling ring v0.17.8
pict-rs>    Compiling io-uring v0.5.13
pict-rs>    Compiling socket2 v0.4.10
pict-rs>    Compiling scoped-tls v1.0.1
pict-rs> error[E0425]: cannot find value `MAP_POPULATE` in crate `libc`
pict-rs>     --> /private/tmp/nix-build-pict-rs-0.5.7.drv-0/pict-rs-0.5.7-vendor.tar.gz/io-uring/src/util.rs:19:42
pict-rs>      |
pict-rs> 19   |                 libc::MAP_SHARED | libc::MAP_POPULATE,
pict-rs>      |                                          ^^^^^^^^^^^^ help: a constant with a similar name exists: `MAP_PRIVATE`
pict-rs>      |
pict-rs>     ::: /private/tmp/nix-build-pict-rs-0.5.7.drv-0/pict-rs-0.5.7-vendor.tar.gz/libc/src/unix/bsd/apple/mod.rs:3314:1
```
@happysalada happysalada changed the title pict-rs: Mark broken pict-rs: Mark broken on darwin Mar 6, 2024
@happysalada happysalada merged commit 00c4e99 into NixOS:master Mar 6, 2024
@9999years 9999years deleted the fix-pict-rs branch March 7, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants