Skip to content

ostree: version bump and removing stale patches#293303

Merged
Mindavi merged 1 commit intoNixOS:masterfrom
danielbarter:danielbarter_ostree
Apr 4, 2024
Merged

ostree: version bump and removing stale patches#293303
Mindavi merged 1 commit intoNixOS:masterfrom
danielbarter:danielbarter_ostree

Conversation

@danielbarter
Copy link
Contributor

@danielbarter danielbarter commented Mar 4, 2024

Addressing #249177. Bumping version of ostree, which also fixes cross compilation.

Previous: #223095

  • bumped version
  • removed old patches (which don't seem to be needed anymore)
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Mar 4, 2024
@danielbarter danielbarter requested a review from copumpkin March 4, 2024 18:10
@danielbarter
Copy link
Contributor Author

Actually, cross compiling issues seem to already be fixed on master anyway.

@danielbarter danielbarter force-pushed the danielbarter_ostree branch from fc779b7 to 1a56b35 Compare March 4, 2024 18:22
@danielbarter danielbarter changed the title ostree: version bump and fix aarch64 cross compilation ostree: version bump and removing stale patches Mar 4, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 4, 2024
@Mindavi Mindavi merged commit bc7644f into NixOS:master Apr 4, 2024
@alyssais
Copy link
Member

Fix for musl: #306727

@jtojnar
Copy link
Member

jtojnar commented May 4, 2024

Two of the patches are still needed for installed tests to pass, I re-added them in #302813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants