Skip to content

Ocsigen#2930

Closed
FlorentBecker wants to merge 19 commits intoNixOS:masterfrom
FlorentBecker:ocsigen
Closed

Ocsigen#2930
FlorentBecker wants to merge 19 commits intoNixOS:masterfrom
FlorentBecker:ocsigen

Conversation

@FlorentBecker
Copy link
Copy Markdown
Contributor

Adds a bunch of derivations in ocaml-land to get a working eliom framework (http://ocsigen.org). The ocsigenserver webserver is not nixosified yet.

@FlorentBecker
Copy link
Copy Markdown
Contributor Author

This needs to be rebased over #2923

@FlorentBecker
Copy link
Copy Markdown
Contributor Author

done (though it's now rebased over #3330 instead)

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Aug 12, 2014

  • It would be nicer if the new meta.license records were from stdenv.lib.licenses (and more precise, as in the case of "LGPL").
  • ocsigen-deriving is missing version (presumably 0.6.2 by the tag).

Otherwise it seems fine to me.

@7c6f434c
Copy link
Copy Markdown
Member

7c6f434c commented Sep 3, 2014

@FlorentBecker: which commits from this PR are not yet applied? I tried to do git am and found that most are.

@FlorentBecker
Copy link
Copy Markdown
Contributor Author

They are applied until 43249a5, ocaml-calendar and onwards are new.

@7c6f434c
Copy link
Copy Markdown
Member

7c6f434c commented Sep 6, 2014

Merged most of this. Please add meta for eliom and ocaml-ipaddr. Please recheck ocsigenserver license.

@7c6f434c
Copy link
Copy Markdown
Member

@FlorentBecker So, is the ocsigenserver license correct?

@FlorentBecker
Copy link
Copy Markdown
Contributor Author

yes it is correct.

@7c6f434c 7c6f434c closed this Sep 18, 2014
@7c6f434c
Copy link
Copy Markdown
Member

I think meta for eliom can be added separately…

@FlorentBecker FlorentBecker deleted the ocsigen branch October 20, 2016 08:01
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: reporter feedback This issue needs the person who filed it to respond 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants