[staging-next] libmicrohttpd: Refactor to inherit#292674
Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom Mar 2, 2024
Merged
[staging-next] libmicrohttpd: Refactor to inherit#292674mweinelt merged 1 commit intoNixOS:staging-nextfrom
mweinelt merged 1 commit intoNixOS:staging-nextfrom
Conversation
The `pkgs/by-name` check currently fails on the staging-next merge into master (https://github.com/NixOS/nixpkgs/actions/runs/8110296543/job/22167262748) because it contains the changes of NixOS#278920, which introduced a "new" package using `callPackage` but not using `pkgs/by-name`. This was never noticed in that PR because CI last ran almosts 2 months ago, which is before the check for new packages was introduced. This wouldn't be a problem normally, it's only become a problem because of the staging-next merge into master, which effectively PRs the same change again (and the `pkgs/by-name` check doesn't try to distinguish between branches). The fix for this is a bit special because it's not actually a "new" package, but rather just a new version of an existing package. The `pkgs/by-name` check can't distinguish between such cases though. So instead we make sure that the `pkgs/by-name` check doesn't think of it as a package using `callPackage` by using the recommendation for multi-versioned packages from NixOS#292214.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The
pkgs/by-namecheck currently fails on the staging-next merge into master (https://github.com/NixOS/nixpkgs/actions/runs/8110296543/job/22167262748) because it contains the changes of #278920, which introduced a "new" package usingcallPackagebut not usingpkgs/by-name.This was never noticed in that PR because CI last ran almosts 2 months ago, which is before the check for new packages was introduced.
This wouldn't be a problem normally, it's only become a problem because of the staging-next merge into master, which effectively PRs the same change again (and the
pkgs/by-namecheck doesn't try to distinguish between branches).The fix for this is a bit special because it's not actually a "new" package, but rather just a new version of an existing package. The
pkgs/by-namecheck can't distinguish between such cases though.So instead we make sure that the
pkgs/by-namecheck doesn't think of it as a package usingcallPackageby using the recommendation for multi-versioned packages from#292214.
Ping @vcunat @mweinelt
Add a 👍 reaction to pull requests you find important.