Skip to content

nixos/plasma5: dont set "plasma" to services.xserver.displayManager.defaultSession#291507

Closed
SaltyKitkat wants to merge 1 commit intoNixOS:masterfrom
SaltyKitkat:plasma-cleanup
Closed

nixos/plasma5: dont set "plasma" to services.xserver.displayManager.defaultSession#291507
SaltyKitkat wants to merge 1 commit intoNixOS:masterfrom
SaltyKitkat:plasma-cleanup

Conversation

@SaltyKitkat
Copy link
Copy Markdown
Contributor

Description of changes

close #291501

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 26, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 26, 2024
@LunNova LunNova requested a review from K900 February 27, 2024 03:25
Copy link
Copy Markdown
Member

@LunNova LunNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is a good idea as there's now nothing to deprioritize plasma (wayland) on plasma 5 when plasma's the only DE enabled.

@K900
Copy link
Copy Markdown
Contributor

K900 commented Feb 27, 2024

What are you trying to do with this and why?

@SuperSandro2000
Copy link
Copy Markdown
Member

From the issue:

However, since plasma wayland seems working fine today, maybe we should remove this workaround.

That isn't true. Plasma 5 Wayland is still buggy and not recommendable. Plasma 6 Wayland is in a usable state.

@SaltyKitkat
Copy link
Copy Markdown
Contributor Author

Thanks for your attention.
I come with this idea because I found that services.xserver.displayManager.defaultSession is set to plasma(x11) as long as I enable plasma desktop. So I have to choose another session every time when sddm choose plasma(x11) as default, which is quite annoying.
After knowing

Plasma 5 Wayland is still buggy and not recommendable.

and #139657 (comment), I found this is not a good idea, and I will close this.

@SaltyKitkat SaltyKitkat deleted the plasma-cleanup branch February 27, 2024 15:01
@SaltyKitkat SaltyKitkat restored the plasma-cleanup branch February 27, 2024 15:01
@SaltyKitkat SaltyKitkat deleted the plasma-cleanup branch February 27, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plasma 5: should not set services.xserver.displayManager.defaultSession

4 participants