Merged
Conversation
wegank
commented
Feb 24, 2024
| @@ -17,22 +17,28 @@ stdenv.mkDerivation rec { | |||
| src = runCommand "${pname}-src-${version}" {} '' | |||
Member
Author
There was a problem hiding this comment.
I'd prefer to keep pname here, but let me know if it should be replaced by mlir.
ofborg
bot
requested review from
Ericson2314,
alyssais,
dtzWill,
lovek323,
rrbutani and
sternenseemann
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
Successfully created backport PR for |
1 task
rrbutani
added
the
6.topic: llvm/clang
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-291050-to-release-23.11 origin/release-23.11
cd .worktree/backport-291050-to-release-23.11
git switch --create backport-291050-to-release-23.11
git cherry-pick -x 023bc57dcc9a464314da2740ef056a740726f6ef |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR addresses comments in #280572.
The rebuilds are due to the removal of
-vinninjaFlags.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.