mesa: default to Apple libGL on Darwin#290421
Closed
K900 wants to merge 15 commits intoNixOS:stagingfrom
Closed
Conversation
ofborg
bot
added
10.rebuild-darwin: 501+
veprbl
reviewed
Feb 21, 2024
github-actions
bot
added
the
6.topic: python
K900
changed the title
ofborg
bot
added
10.rebuild-darwin: 1001-2500
Contributor
Author
|
So, update on this: whatever happened in Qt in the meantime fixed the lrelease crashes, so we should be largely unblocked here. I'm running nixpkgs-review on the community builder and will post results here, but right now I'm looking at ~100-200 projected total failures, and most of them seem unrelated to this change. |
Contributor
Author
|
Result of 903 packages marked as broken and skipped:
305 packages failed to build:
906 packages built:
|
wegank
added
the
2.status: merge conflict
ofborg
bot
removed
the
2.status: merge conflict
reckenrode
reviewed
Jun 10, 2024
Contributor
There was a problem hiding this comment.
This won’t work with overrideSDK. The OpenGL framework needs to be added to propagatedBuildInputs, so overrideSDK can know about the framework dependency being propagated.
K900
changed the title
This isn't really related to this change, but makes nixpkgs-review runs a lot nicer.
There are probably more cases like this; it might be good to have a top‐level glut package that resolves to either GLUT or freeglut depending on platform?
Needed for Darwin.
Contributor
Author
|
OK, so I think we should be done with all the major regressions here. |
ofborg
bot
added
10.rebuild-darwin-stdenv
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
Can you add a doc entry to when to use libGL/libGLU/libGLX/libglvnd/mesa? I am very confused at this point, what to tell people to use in reviews.
Contributor
Author
|
libGL, libGLU and libGLX are different libraries, so you use the ones you need. Generally you shouldn't explicitly use libglvnd or mesa unless you know exactly what you're doing. |
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
Contributor
Author
|
@ofborg eval |
ofborg
bot
added
10.rebuild-darwin: 1001-2500
Contributor
Author
|
@emilazy has a better PR in the works, so I'm closing this one. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is @reckenrode's patch from #233265 (comment) , followed by me adding Mesa explicitly in a few places that depend on specifically Mesa/GLX. This should reduce the amount of Mesa dependencies on Darwin from ~800 to ~100 even if we re-add it to all the other packages.
Now someone just needs to go through all the regressions and triage them.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.