Skip to content

qownnotes: 24.2.0 -> 24.2.3#289264

Merged
NickCao merged 1 commit intoNixOS:masterfrom
pbek:feature/qownnotes-update
Feb 16, 2024
Merged

qownnotes: 24.2.0 -> 24.2.3#289264
NickCao merged 1 commit intoNixOS:masterfrom
pbek:feature/qownnotes-update

Conversation

@pbek
Copy link
Contributor

@pbek pbek commented Feb 16, 2024

Description of changes

24.2.3

  • support was added for the QOwnNotes Web Companion browser extension
    to also allow deleting of bookmarks in the current note
    (for #57)
  • it was made sure, that the first password field gets the focus in password
    dialogs, if the tab order doesn't work properly

24.2.2

  • the spellchecker is now correctly turned off in inline code blocks, when there are more of one
    in one line (for #2955, thank you, @Waqar144)
  • added more Croatian, Korean, Swedish, Dutch, Italian translation (thank you
    milotype, venusgirl, dzenan, stephanp, gryp2)
  • a new release of the QOwnNotes Web Companion browser extension 2024.2.4 was released
    • the minimum height of the popup was raised to 300px to allow
      dialogs to be shown fully if there is little content
    • now only a delete button is shown in the bookmarks list if the bookmark
      can be deleted (for #57)
    • fixed a problem where links without name couldn't be opened when the link directly was clicked
    • there now is a new private mode switch, that allows opening bookmarks in
      a private window (for #58)

24.2.1

  • support was added for the new QOwnNotes Web Companion browser extension 2024.2.2
    to allow deleting of bookmarks (for #57)
  • added more Croatian, Arabic translation (thank you milotype, noureddin)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Feb 16, 2024
@pbek
Copy link
Contributor Author

pbek commented Feb 16, 2024

@NickCao, in the tests, since the OCR doesn't seem to be able anymore to handle the main window and I didn't manage to get most of the other testing ways to work in non-root mode and in root-mode, I'm now checking a file that will be created, and this test runs finally through for me.

@pbek pbek requested a review from NickCao February 16, 2024 12:13
@ofborg ofborg bot requested a review from totoroot February 16, 2024 12:34
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 16, 2024
@pbek
Copy link
Contributor Author

pbek commented Feb 16, 2024

The tests seem to run through now. 😅

Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try to fix the tests later.

@NickCao NickCao merged commit 97f7816 into NixOS:master Feb 16, 2024
@pbek
Copy link
Contributor Author

pbek commented Feb 16, 2024

Thank you!
The current test tries to create a new note with the shortcut and waits for the note file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments