Merged
Conversation
Contributor
Author
|
@NickCao, in the tests, since the OCR doesn't seem to be able anymore to handle the main window and I didn't manage to get most of the other testing ways to work in non-root mode and in root-mode, I'm now checking a file that will be created, and this test runs finally through for me. |
Contributor
Author
|
The tests seem to run through now. 😅 |
NickCao
approved these changes
Feb 16, 2024
Member
NickCao
left a comment
There was a problem hiding this comment.
We can try to fix the tests later.
Contributor
Author
|
Thank you! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
24.2.3
to also allow deleting of bookmarks in the current note
(for #57)
dialogs, if the tab order doesn't work properly
24.2.2
in one line (for #2955, thank you, @Waqar144)
milotype, venusgirl, dzenan, stephanp, gryp2)
dialogs to be shown fully if there is little content
can be deleted (for #57)
a private window (for #58)
24.2.1
to allow deleting of bookmarks (for #57)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)