Open
Conversation
ofborg
bot
added
8.has: package (new)
FliegendeWurst
approved these changes
Oct 29, 2024
wegank
added
the
12.approvals: 1
Contributor
|
Result of 1 package built:
|
FliegendeWurst
changed the title
FliegendeWurst
changed the title
FliegendeWurst
added
the
2.status: needs-changes
wegank
added
the
2.status: stale
wolfgangwalther
requested changes
Jan 4, 2025
| vendorHash = "sha256-8KRjugc+Bde0HqjzpY0Ib/JbsoIwEwJTKmk/EvHnaME="; | ||
|
|
||
| meta = with lib; { | ||
| description = "A small reverse proxy that can front existing gRPC servers and expose their functionality using gRPC-Web protocol"; |
Contributor
There was a problem hiding this comment.
Suggested change
| description = "A small reverse proxy that can front existing gRPC servers and expose their functionality using gRPC-Web protocol"; | |
| description = "Small reverse proxy that can front existing gRPC servers and expose their functionality using gRPC-Web protocol"; |
Comment on lines
+16
to
+23
| meta = with lib; { | ||
| description = "A small reverse proxy that can front existing gRPC servers and expose their functionality using gRPC-Web protocol"; | ||
| homepage = "https://github.com/improbable-eng/grpc-web"; | ||
| license = licenses.asl20; | ||
| platforms = platforms.unix; | ||
| maintainers = with maintainers; [ bouk ]; | ||
| mainProgram = "grpcwebproxy"; | ||
| }; |
Contributor
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| description = "A small reverse proxy that can front existing gRPC servers and expose their functionality using gRPC-Web protocol"; | |
| homepage = "https://github.com/improbable-eng/grpc-web"; | |
| license = licenses.asl20; | |
| platforms = platforms.unix; | |
| maintainers = with maintainers; [ bouk ]; | |
| mainProgram = "grpcwebproxy"; | |
| }; | |
| meta = { | |
| description = "A small reverse proxy that can front existing gRPC servers and expose their functionality using gRPC-Web protocol"; | |
| homepage = "https://github.com/improbable-eng/grpc-web"; | |
| license = lib.licenses.asl20; | |
| platforms = lib.platforms.unix; | |
| maintainers = with lib.maintainers; [ bouk ]; | |
| mainProgram = "grpcwebproxy"; | |
| }; |
| @@ -0,0 +1,24 @@ | |||
| { buildGoModule, fetchFromGitHub, lib }: | |||
Contributor
There was a problem hiding this comment.
This needs a nixfmt run.
| src = fetchFromGitHub { | ||
| owner = "improbable-eng"; | ||
| repo = "grpc-web"; | ||
| rev = "v${version}"; |
Contributor
There was a problem hiding this comment.
Probably:
Suggested change
| rev = "v${version}"; | |
| tag = "v${version}"; |
|
|
||
| meta = with lib; { | ||
| description = "A small reverse proxy that can front existing gRPC servers and expose their functionality using gRPC-Web protocol"; | ||
| homepage = "https://github.com/improbable-eng/grpc-web"; |
Contributor
There was a problem hiding this comment.
Suggested change
| homepage = "https://github.com/improbable-eng/grpc-web"; | |
| homepage = "https://github.com/improbable-eng/grpc-web"; | |
| changelog = "https://github.com/improbable-eng/grpc-web/blob/v${version}/CHANGELOG.md"; |
stale
bot
removed
the
2.status: stale
nixpkgs-ci
bot
added
the
2.status: stale
2 tasks
nixpkgs-ci
bot
removed
the
2.status: stale
nixpkgs-ci
bot
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.