Merged
Conversation
|
@jtojnar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dyrnade, @lheckemann and @edolstra to be potential reviewers. |
orivej
reviewed
Nov 2, 2017
Contributor
There was a problem hiding this comment.
Why is the wrapper no longer needed?
Member
Author
There was a problem hiding this comment.
Switched to wrapGAppsHook. I still wrap PYTHONPATH through wrapPrefixVariables. PATH does not seem to be needed.
orivej
approved these changes
Nov 2, 2017
Contributor
|
I think you could get it working in chromium/chrome out of the box by adding this lines into module: |
8 tasks
Contributor
|
@GrahamcOfBorg eval |
78725ad to
c208d59
Compare
c208d59 to
fe11f46
Compare
fe11f46 to
062cafa
Compare
Member
Author
|
@deedrah I merged your firefox patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native connector requires a D-Bus service. For firefox it is also necessary to enable the host connector, for example by setting
nixpkgs.config.firefox.enableGnomeExtensionstotrue.Unfortunately, it still does not work because the browsers require manifest files, Chromium in
/etc/chromium/native-messaging-hostsand Firefox in/usr/lib64/mozilla/native-messaging-hosts.One way to make it work is to copy the files to local folder:
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)cc @dyrnade