lib/ flake: fix lib.version
#288812
Merged
lib/ flake: fix lib.version
#288812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
force-pushed
the
lib-flake-version
branch
from
22e2559 to
e03c5e9
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
infinisil
approved these changes
Feb 26, 2024
|
Oh there's a conflict due to #290831 now that needs to be fixed |
Manually tested with nix-repl> :lf path:lib nix-repl> lib.version
This way we don't have to make sure they're in sync, and we remove a small step from the release process.
This is not new and should have been written when .editorconfig was introduced.
roberth
force-pushed
the
lib-flake-version
branch
from
4d54d8e to
324a7aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Afaik, this makes the
lib/flake fully functional even when the parent directory is dropped, which can be done with:"${./lib}"path:flakereffetchTreefeatureThe latter could be simplified and ideally be made redundant.
This PR is implemented in two commits, for bisection if needed:
<nixpkgs/.version>, andThe third commit tests the
versionattribute in an isolatedlib/tree.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.