links2: fix darwin build

[afh]

Description of changes

• Modernize package by using finalAttrs instead of rec and hash instead of sha256
• Disable implicit-int warning to fix failing configurePhase thinking compiler is unable to produce binaries due to implicit int being disallowed in C99 and above.
• Add libavif to buildInputs to fix failing configurePhase due to avif.h header not being found
• Disable graphics on Darwin to fix failing configurePhase due to graphics drivers not being found

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3439

[afh]

Thanks for merging @7c6f434c, much appreciated! 🙂

[SuperSandro2000]

Suggested change

	url = "${finalAttrs.meta.homepage}/download/links-${finalAttrs.version}.tar.bz2";
	url = "http://links.twibright.com/download/links-${finalAttrs.version}.tar.bz2";

using meta.homepage here is not very correct or future proof. If meta.homepage gets changed in the future this will likely be forgotten

[afh]

That makes sense, @SuperSandro, is this important enough to you, that you'd accept a PR for it or it is something that should rather be addressed with the next update to the package?

[kirillrdy]

feel free to make PR now, me or @SuperSandro2000 happy to have a look at it

[afh]

Sure thing, @kirillrdy, here's the PR: #289130

[7c6f434c]

If meta.homepage gets changed in the future this will likely be forgotten

Note that if the domain changes in the future, the URL 100% needs changing, but there is a chance that the URL structure is the same, so I am not sure how this cleanup can ever be useful.

[kirillrdy]

this is similar to #277994

for links2 its most likely that url and homepage will go in sync, but that's not the case for a lot of other derivations

eg homepage can change to be different domain but src remains on github, or sometimes they go backwards