Skip to content

tribler: deps pin pydantic_1#288293

Merged
mkg20001 merged 1 commit intoNixOS:masterfrom
brrrocking:tribler-pydantic_1
Feb 12, 2024
Merged

tribler: deps pin pydantic_1#288293
mkg20001 merged 1 commit intoNixOS:masterfrom
brrrocking:tribler-pydantic_1

Conversation

@brrrocking
Copy link
Contributor

@brrrocking brrrocking commented Feb 12, 2024

Description of changes

Pin dependency (pydantic -> pydantic_1); this follows the change to pydantic major version in #269633

This is required as Tribler requires pydantic==1.10.11 and the pydantic v2 API includes breaking changes which will cause it to fail to launch (reference).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Feb 12, 2024
@ofborg ofborg bot requested review from mkg20001, viric and xvapx February 12, 2024 14:10
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 12, 2024
@mkg20001 mkg20001 merged commit b5d14a4 into NixOS:master Feb 12, 2024
@brrrocking brrrocking deleted the tribler-pydantic_1 branch February 12, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants