pkgs/stdenv/linux/make-bootstrap-tools-cross.nix: allow entries for t… #288250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
the
6.topic: cross-compilation
Contributor
Author
ofborg
bot
added
10.rebuild-darwin: 0
OPNA2608
reviewed
Feb 15, 2024
Contributor
OPNA2608
left a comment
OPNA2608
left a comment
There was a problem hiding this comment.
Grammar nit, otherwise +1 from my side.
…o-be uplaoded targets Newly added targets should be fine to be added as hudra jobs before the first uplaod happens. Co-authored-by: Cosima Neidahl <opna2608@protonmail.com>
trofi
force-pushed
the
make-bootstrap-tools-cross-new-target
branch
from
72b6604 to
a0f80e9
Compare
OPNA2608
approved these changes
Feb 15, 2024
Contributor
OPNA2608
left a comment
OPNA2608
left a comment
There was a problem hiding this comment.
Gives me a clear way of moving forward with my PR, so LGTM.
delroth
added
the
12.approvals: 1
ghost
merged commit
13 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o-be uplaoded targets
Newly added targets should be fine to be added as hudra jobs before the first uplaod happens.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.