Add package for Typespeed game#2876
Merged
7c6f434c merged 13 commits intoNixOS:masterfrom Jun 9, 2014
Merged
Conversation
Member
|
I think if you add a significant patch, it is better to add yourself as a maintainer. Also, the preferred way of listing licenses is via stdenv.lib.licenses. |
Contributor
Author
|
Alright, I added myself as a maintainer and set the license as you suggested. |
7c6f434c
added a commit
that referenced
this pull request
Jun 9, 2014
Add package for Typespeed game
Member
|
It's probably also better to squash your work into few coherent commits after you're done hacking on it: no need for everyone to see files added by mistake &c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I packaged the classic Typespeed typing game for Nix. By default, typespeed stores high score files and such in /var and /etc, which is problematic in Nix. I wrote a rather lengthy patch that creates a ~/.typespeed directory with ~/.typespeed/score and ~/.typespeed/config when typespeed is started.
I wasn't sure how I should add myself as a package maintainer, so I left that out for now.