linux/generic: take a kernelTarget argument#287122
Draft
RaitoBezarius wants to merge 2 commits intoNixOS:masterfrom
Draft
linux/generic: take a kernelTarget argument#287122RaitoBezarius wants to merge 2 commits intoNixOS:masterfrom
kernelTarget argument#287122RaitoBezarius wants to merge 2 commits intoNixOS:masterfrom
Conversation
…tall targets Nowadays, most architectures supports `KBUILD_IMAGE` which is set by the architecture-specific Makefile or can be overriden by the user Before that, we were using Makefile "install targets" such as "uinstall" for uImage, "zinstall" for zImage, etc. We move them into a "legacy" list which is used by default if `kernelTarget` is null.
For completeness, this may be needed for some legacy software or to simplify further refactors. Prefer KBUILD_IMAGE and kernelTarget.
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
|
@RaitoBezarius It would be great to have the changes from #277975 incorporated here as well |
Member
Author
I recommend reading the initial PR :). Enabling ZBOOT is the trivial part of this. Fixing the layering violation is the hard part and then whatever can be done about ZBOOT. This will take time though to get this right without breaking the existing builds. |
18 tasks
wegank
added
the
2.status: merge conflict
wegank
added
the
2.status: stale
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Deprecates the legacy targets too.
Nowadays, most architectures supports
KBUILD_IMAGEwhich isset by the architecture-specific Makefile or can be overriden by the user
Before that, we were using Makefile "install targets" such as "uinstall" for uImage,
"zinstall" for zImage, etc.
We move them into a "legacy" list which is used by default if
kernelTargetis null.This is a retake of #244706 containing the old amjoseph comments.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.