c-blosc2: init at 2.13.2, python3Packages.blosc2: 2.3.2 -> 2.5.1#287081
c-blosc2: init at 2.13.2, python3Packages.blosc2: 2.3.2 -> 2.5.1#287081risicle merged 2 commits intoNixOS:masterfrom
Conversation
642f0bd to
7713547
Compare
|
pkgs/by-name check is failing but I don't really want to separate this package from (cc @infinisil ) |
|
@risicle Yeah i wouldn't separate it in that way. Check out #285922 (comment) for my recommendation |
|
Hmm neither of those really feel appropriate here. Have you considered the ghetto option of simply making the checker ignore any attrnames ending in a digit? |
I'd expect this to work out just fine: inherit (callPackages ../development/libraries/c-biosc { })
c-biosc c-biosc2;Or is there a problem with this?
I have considered it, but it feels like a hack, which I'm really not fond of! It's actually really interesting to have this restriction, because it highlights the problem of multiple package versions and encourages exploration of better solutions. Even the above recommendation already has the benefit of being explicit about multiple attributes coming from the same source, which is a step in the right direction for future improvements. |
largely copied from c-blosc, however c-blosc2 is developed under a separate tree and has a different e.g. pkg-config name so probably warrants a separate package as it will diverge
also don't need fetchSubmodules if we're not using the vendored c-blosc2
7713547 to
11d1976
Compare
|
Ok I've gone with that approach, but FWIW it also feels like a bit of a hack that doesn't serve much purpose but to placate the CI. And I'd much rather have a hacky CI than to fill nixpkgs with all these hacks that don't really add any value. |
|
Sometimes adding a hack to CI is ok, but exempting packages with a number at the end is overly broad to me. So I think this is the right solution, for now. We can always reconsider later if we get tens or hundreds of packages like this. |
Description of changes
c-blosc2package largely copied fromc-blosc, howeverc-blosc2is developed under a separate tree and has a different e.g. pkg-config name so probably warrants a separate package as it will likely diverge.This allows us to switch
python3Packages.blosc2to use this systemc-blosc2instead of its own bundled version.Also built
pkgsStatic,pkgsMusl,pkgsCross.aarch64-multiplatform,pkgsi686Linuxversions of c-blosc2.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.