sourcehut: update all components#286993
Merged
tomberek merged 12 commits intoNixOS:masterfrom Feb 10, 2024
Merged
Conversation
github-actions
bot
added
6.topic: nixos
mfrw
reviewed
Feb 7, 2024
Member
mfrw
left a comment
mfrw
left a comment
There was a problem hiding this comment.
A few cosmetic suggestions: s/sha256/hash/g :)
ofborg
bot
added
11.by: package-maintainer
Signed-off-by: Christoph Heiss <christoph@c8h4.io>
Signed-off-by: Christoph Heiss <christoph@c8h4.io>
Signed-off-by: Christoph Heiss <christoph@c8h4.io>
Also refactor it to the same common structure as all other sourcehut packages, thus opening the possibility to even further simplify this in the future. Signed-off-by: Christoph Heiss <christoph@c8h4.io>
Also refactor it to the same common structure as all other sourcehut packages, thus opening the possibility to even further simplify this in the future. Signed-off-by: Christoph Heiss <christoph@c8h4.io>
Also refactor it to the same common structure as all other sourcehut packages, thus opening the possibility to even further simplify this in the future. Signed-off-by: Christoph Heiss <christoph@c8h4.io>
Signed-off-by: Christoph Heiss <christoph@c8h4.io>
Signed-off-by: Christoph Heiss <christoph@c8h4.io>
Also refactor it to the same common structure as all other sourcehut packages, thus opening the possibility to even further simplify this in the future. Signed-off-by: Christoph Heiss <christoph@c8h4.io>
christoph-heiss
force-pushed
the
srht-updates-next-round
branch
from
2a1b8f8 to
b8f5bf6
Compare
This provides the same common structure as all other sourcehut packages, thus opening the possibility to even further simplify this in the future. Signed-off-by: Christoph Heiss <christoph@c8h4.io>
Signed-off-by: Christoph Heiss <christoph@c8h4.io>
I worked already a lot on this stuff, esp. modules - so it just makes sense. Signed-off-by: Christoph Heiss <christoph@c8h4.io>
christoph-heiss
force-pushed
the
srht-updates-next-round
branch
from
b8f5bf6 to
62854c0
Compare
Member
|
Result of 2 packages blacklisted:
21 packages built:
|
nessdoor
approved these changes
Feb 8, 2024
Contributor
nessdoor
left a comment
nessdoor
left a comment
There was a problem hiding this comment.
Thank you for taking on maintainership and keeping track of upstream changes! All those gqlgen dependencies always make me so nervous...
+1 for the intention of factoring common parts more rationally, all these versions and hashes scattered around make version bumps so very tedious.
I also tested compilation on an AArch64 box; results follow.
Result of nixpkgs-review pr 286993 run on aarch64-linux 1
1 package blacklisted:
- nixos-install-tools
21 packages built:
- sourcehut.buildsrht
- sourcehut.buildsrht.dist
- sourcehut.coresrht
- sourcehut.coresrht.dist
- sourcehut.gitsrht
- sourcehut.gitsrht.dist
- sourcehut.hgsrht
- sourcehut.hgsrht.dist
- sourcehut.hubsrht
- sourcehut.hubsrht.dist
- sourcehut.listssrht
- sourcehut.listssrht.dist
- sourcehut.mansrht
- sourcehut.mansrht.dist
- sourcehut.metasrht
- sourcehut.metasrht.dist
- sourcehut.pagessrht
- sourcehut.pastesrht
- sourcehut.pastesrht.dist
- sourcehut.todosrht
- sourcehut.todosrht.dist
nessdoor
added
12.approvals: 1
tomberek
approved these changes
Feb 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a new round of updates across the sourcehut stack. Keeping close to upstream should help us all around, as big version upgrades can be painful.
Pretty minor version upgrades for most packages, nothing should be broken (or at least; not more than before).
It has also been tested on top of the incoming, much more expansive testsuite in #271324.
Two more things to note:
todo,man,lists,hubandhgpackages, such that they are all now pretty similar. I would then combine them using some common expression and factor out most of the now-common stuff between all of them as a next step.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.