rocmPackages.clr: backport bf16 compilation fix#286720
Merged
happysalada merged 1 commit intoNixOS:masterfrom Feb 18, 2024
Merged
rocmPackages.clr: backport bf16 compilation fix#286720happysalada merged 1 commit intoNixOS:masterfrom
happysalada merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
18 tasks
Contributor
|
@lovesegfault @NixOS/rocm-maintainers |
Contributor
|
Alright imagining people are busy. I would say let's go with this for now, and if there is anything that is amiss, feel free to comment on it. |
13 tasks
mschwaig
added a commit
to mschwaig/nixpkgs
that referenced
this pull request
Mar 22, 2024
NixOS#286720 introduced these patches to address a specific compilation error mentioned in ROCm/hip#3403, but added them to the source tree because they were originally for ROCm 6. For ROCm 6, we can now switch to using fetchpatch to get the original commits as patches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Wanted for vllm update, issue details: ROCm/hip#3403
Patches are not fetched using fetchpatch, because they are slightly altered for ROCm 5.7 (They were originally for ROCm 6)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.