nixos/filesystems: init overlayfs#286176
Merged
lheckemann merged 3 commits intoNixOS:masterfrom Feb 9, 2024
Merged
Conversation
nikstur
requested review from
ElvishJerricco,
JulienMalka,
Ma27,
RaitoBezarius,
arianvp and
lheckemann
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
ElvishJerricco
requested changes
Feb 4, 2024
Contributor
ElvishJerricco
left a comment
ElvishJerricco
left a comment
There was a problem hiding this comment.
This should be useful!
nikstur
force-pushed
the
writable-overlays
branch
from
8aba5d2 to
729c772
Compare
ElvishJerricco
approved these changes
Feb 4, 2024
delroth
added
the
12.approvals: 1
nikstur
force-pushed
the
writable-overlays
branch
from
729c772 to
12b9fde
Compare
Contributor
Author
|
Added the overlay kmod in the initrd and changed wantedBy of the fs from default.target to local-fs.target. |
Contributor
Author
|
@ofborg test filesystems-overlayfs |
Ma27
reviewed
Feb 4, 2024
Ma27
reviewed
Feb 4, 2024
Ma27
reviewed
Feb 4, 2024
delroth
removed
the
12.approvals: 1
Member
|
A few minor notes, but other than that it looks nice 👍 |
arianvp
reviewed
Feb 4, 2024
ElvishJerricco
requested changes
Feb 4, 2024
ElvishJerricco
requested changes
Feb 7, 2024
nikstur
force-pushed
the
writable-overlays
branch
from
12b9fde to
5ce57a3
Compare
Contributor
Author
|
@ofborg test filesystems-overlayfs |
nikstur
force-pushed
the
writable-overlays
branch
from
5ce57a3 to
bbce103
Compare
Contributor
Author
|
@ofborg test filesystems-overlayfs |
h7x4
added
8.has: module (new)
ElvishJerricco
approved these changes
Feb 8, 2024
delroth
added
the
12.approvals: 1
Member
|
See #287523 for the dependency issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds an abstraction to conveniently create writable and read only overlays.
We use functionality like this in multiple places in Nixpkgs:
In further PRs we can replace all of these with the new abstraction. However, these require different levels of care to not break tests etc. so we shouldn't change them all at once.
Shoutout to @lheckemann for helping in the final stages of the design.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.