Skip to content

vimPlugins.gitsigns: add git as a dependency#285747

Closed
GaetanLepage wants to merge 1 commit intoNixOS:masterfrom
GaetanLepage:gitsigns
Closed

vimPlugins.gitsigns: add git as a dependency#285747
GaetanLepage wants to merge 1 commit intoNixOS:masterfrom
GaetanLepage:gitsigns

Conversation

@GaetanLepage
Copy link
Copy Markdown
Contributor

@GaetanLepage GaetanLepage commented Feb 2, 2024

Description of changes

This plugin needs git. So, let's have it in the dependencies.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage requested a review from teto February 2, 2024 08:50
@github-actions github-actions bot added the 6.topic: vim Advanced text editor label Feb 2, 2024
@GaetanLepage
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 285747 run on x86_64-linux 1

1 package built:
  • vimPlugins.gitsigns-nvim

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 2, 2024
@GaetanLepage
Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 285747 run on x86_64-linux 1

1 package built:
  • vimPlugins.gitsigns-nvim

@GaetanLepage
Copy link
Copy Markdown
Contributor Author

It is unsure whereas the binary will be correctly propagated.
Also, adding this could lead to collisions. Hence, I drop this PR.

@figsoda
Copy link
Copy Markdown
Member

figsoda commented Feb 7, 2024

It is unsure whereas the binary will be correctly propagated.

currently it wouldn't because of how dependencies work, I opened #208029 a while ago to try to implement this as pathDependencies, but it kinda just went stale

@GaetanLepage GaetanLepage deleted the gitsigns branch June 18, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants