Skip to content

python3Packages.xformers: 0.03 -> 0.0.23.post1, add cuda support#285495

Merged
happysalada merged 1 commit intoNixOS:masterfrom
CertainLach:xformers/update-0.0.23.post1
Feb 3, 2024
Merged

python3Packages.xformers: 0.03 -> 0.0.23.post1, add cuda support#285495
happysalada merged 1 commit intoNixOS:masterfrom
CertainLach:xformers/update-0.0.23.post1

Conversation

@CertainLach
Copy link
Member

@CertainLach CertainLach commented Feb 1, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 1, 2024
@CertainLach
Copy link
Member Author

Also something needs to be done with update script, as xformers was downgraded twice at this point:
image
#271586 (comment)

@ofborg ofborg bot requested a review from happysalada February 1, 2024 08:31
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 1, 2024
@Tungsten842
Copy link
Member

Could you update this to v0.0.24?

@CertainLach
Copy link
Member Author

I can, but I won't be able to test it this week.
I have only tested 0.0.23.post1 with vllm on A100.

@happysalada
Copy link
Contributor

Result of nixpkgs-review pr 285495 run on x86_64-linux 1

2 packages built:
  • python311Packages.xformers
  • python311Packages.xformers.dist

@CertainLach CertainLach force-pushed the xformers/update-0.0.23.post1 branch from b23cb40 to 364661d Compare February 3, 2024 13:07
@ofborg ofborg bot requested a review from happysalada February 3, 2024 13:44
@happysalada happysalada merged commit 84d1ae1 into NixOS:master Feb 3, 2024
@happysalada
Copy link
Contributor

ok let's figure out the update script in a separate step.
Thank you for the contribution!
If you want to do the vllm init, feel free to tag me for it as well.

@CertainLach CertainLach deleted the xformers/update-0.0.23.post1 branch February 3, 2024 15:14
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set passthru.skipBulkUpdate = true to prevent this from happening again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants