nixVersions.nix_2_3: backport tests/check.sh / tests/add.sh race fix#284744
Closed
trofi wants to merge 1 commit intoNixOS:masterfrom
Closed
nixVersions.nix_2_3: backport tests/check.sh / tests/add.sh race fix#284744trofi wants to merge 1 commit intoNixOS:masterfrom
trofi wants to merge 1 commit intoNixOS:masterfrom
Conversation
Without the change the evals fail frequently against `staging` when `stdenv` rebbuilds `nix-2.3`. Recent example is NixOS#284542 Let's backport the patch until new `nix-2.3` release is cut.
Contributor
Author
|
The test still fails, probably needs more fixes. Dropping for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change the evals fail frequently against
stagingwhenstdenvrebbuildsnix-2.3. Recent example is #284542Let's backport the patch until new
nix-2.3release is cut.Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.