dhcpcd: 10.0.6 -> 10.1.0

[deepfire]

This works around NetworkConfiguration/dhcpcd#291, by bumping dhcpcd to the latest released.

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[deepfire]

Trick question -- why a dhcpcd bump causes 2500+ rebuilds?

[kirillrdy]

@deepfire greetings !

can you check that link to the issue you have posted is correct ?

Trick question -- why a dhcpcd bump causes 2500+ rebuilds?

silly answer would be because it has a lot of direct and indirect reverse dependencies, are you after any specific dependency ?

EDIT: networkmanager depends on dhcpcd, which means pretty much all desktop environments need to be rebuilt

have you tried updating to 10.0.6 ? #281704
also #253129

[deepfire]

@kirillrdy, my apologies, I've used a repo-local link -- here's the proper link to the issue: NetworkConfiguration/dhcpcd#291

[deepfire]

Update: NetworkConfiguration/dhcpcd#291 (comment)

[deepfire]

Trick question -- why a dhcpcd bump causes 2500+ rebuilds?

silly answer would be because it has a lot of direct and indirect reverse dependencies, are you after any specific dependency ?

EDIT: networkmanager depends on dhcpcd, which means pretty much all desktop environments need to be rebuilt

I guess that's the essence of my actual question -- I've seen that the full path to dhcpcd is essentially hard-coded into the build process -- and I wonder if that's indeed prudent and unavoidable -- say by using environement variables in NetworkManager and using makeWrapper to split the N-M libraries (now devoid of direct dependency) from the wrapped runtime (that'll remain dependent on dhcpcd directly)..

[kirillrdy]

N-M libraries

not sure what those are. but for as long as anything uses store path its unavoidable.

and using store paths is the whole point of nix, so that this precise version of NetworkManager was built/tested with that precise version of dhcpcd

[deepfire]

N-M libraries

Sorry, I garbled the overlong name 0f NetworkManager.

not sure what those are. but for as long as anything uses store path its unavoidable.

and using store paths is the whole point of nix, so that this precise version of NetworkManager was built/tested with that precise version of dhcpcd

1. Imagine that NetworkManager no longer has to hard-code the dhcpcd dependency at configure time -- instead taking it via environment variable.
2. Then we can use makeWrapper, as I mentioned before, to separate the dhcpcd-blissful base package (that others can depend on), from the system service that uses the wrapped binary with environment pointing to dhcpcd.

[kirillrdy]

N-M libraries

Sorry, I garbled the overlong name 0f NetworkManager.

not sure what those are. but for as long as anything uses store path its unavoidable.
and using store paths is the whole point of nix, so that this precise version of NetworkManager was built/tested with that precise version of dhcpcd

1. Imagine that NetworkManager no longer has to hard-code the `dhcpcd` dependency at configure time -- instead taking it via environment variable.

2. Then we can use `makeWrapper`, as I mentioned before, to separate the `dhcpcd`-blissful base package (that others can depend on), from the system service that uses the wrapped binary with environment pointing to `dhcpcd`.

• that would work if you expect users to install dhcpcd, not sure where would you put such information
• by not specifying dhcpcd as a dependency we would miss ability to test networkmanager when dhcpd updated ( eg this PR )

maybe in the future https://nixos.wiki/wiki/Ca-derivations can fix this

[deepfire]

Updated, as Nixpkgs master still suffers from NetworkConfiguration/dhcpcd#291

[deepfire]

cc @kirillrdy

[yorickvP]

Maybe this should target staging because of the mass rebuild?

[deepfire]

@yorickvP @wegank, rebased onto staging.

[deepfire]

Rebases suggested by the approving reviewer are disincentivized, I see ; -)