Skip to content

Comments

tests.cross.sanity: fix eval by fixing qt5.qutebrowser reference#283737

Merged
Artturin merged 1 commit intoNixOS:masterfrom
trofi:tests.cross.sanity-fix-eval
Jan 25, 2024
Merged

tests.cross.sanity: fix eval by fixing qt5.qutebrowser reference#283737
Artturin merged 1 commit intoNixOS:masterfrom
trofi:tests.cross.sanity-fix-eval

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Jan 25, 2024

Without the change the eval fails as:

$ nix build --no-link -f. tests.cross.sanity

   error: attribute 'qutebrowser' missing

   at pkgs/test/cross/default.nix:157:5:

      156|     # Two web browsers -- exercises almost the entire packageset
      157|     pkgs.pkgsCross.aarch64-multiplatform.qt5.qutebrowser
         |     ^
      158|     pkgs.pkgsCross.aarch64-multiplatform.firefox

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Without the change the eval fails as:

    $ nix build --no-link -f. tests.cross.sanity

       error: attribute 'qutebrowser' missing

       at pkgs/test/cross/default.nix:157:5:

          156|     # Two web browsers -- exercises almost the entire packageset
          157|     pkgs.pkgsCross.aarch64-multiplatform.qt5.qutebrowser
             |     ^
          158|     pkgs.pkgsCross.aarch64-multiplatform.firefox
@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 25, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 25, 2024
@Artturin Artturin merged commit 798d0c0 into NixOS:master Jan 25, 2024
@trofi trofi deleted the tests.cross.sanity-fix-eval branch January 25, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants