Skip to content

Conversation

@bryango
Copy link
Member

@bryango bryango commented Jan 25, 2024

Description of changes

Fix pytest failure: https://hydra.nixos.org/build/247211840/nixlog/1 since: #282506.
This may or may not fix many downstream packages in staging-next.
See upstream scikit-learn/scikit-learn#27628 for details.

Changelog: https://scikit-learn.org/stable/whats_new/v1.4.html

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 25, 2024
@bryango bryango changed the title [staging-next] python311Packages.scikit-learn: 1.3.2 -> 1.4.0-1 [staging-next] python311Packages.scikit-learn: 1.3.2 -> 1.4.0 Jan 25, 2024
@ofborg ofborg bot requested a review from DavHau January 25, 2024 05:40
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jan 25, 2024
@bryango bryango marked this pull request as ready for review January 25, 2024 05:44
@bryango bryango requested review from doronbehar and vcunat January 25, 2024 05:45
@vcunat
Copy link
Member

vcunat commented Jan 25, 2024

Sounds OK to me, though I don't know this package in particular. The ChangeLog shows lots of API changes, but I think that's relatively common for python packages.

@bryango
Copy link
Member Author

bryango commented Jan 25, 2024

I also do not understand the full repercussions of this version bump... Maybe some python expert should take a look? 😉 I failed to nixpkgs-review it as the change seems to be too large for my laptop...

Update: I went through the changelog and the number of API changes is terrifying. I am okay for this to be closed if we decided that it is too soon for a version bump. One can simply disable the test_singular_matrix to fix the build for now.

@ofborg eval

@vcunat
Copy link
Member

vcunat commented Jan 25, 2024

Let me merge this PR as is, so that the build is fixed at least. Further improvements can be done later.

@vcunat vcunat merged commit 3d8934d into NixOS:staging-next Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants