Skip to content

intel-graphics-compiler: 1.0.15136.4 -> 1.0.15610.11 and some of it's direct dependencies#283531

Merged
NickCao merged 4 commits intoNixOS:masterfrom
SuperSandro2000:intel-graphics-compiler-2
Jan 28, 2024
Merged

intel-graphics-compiler: 1.0.15136.4 -> 1.0.15610.11 and some of it's direct dependencies#283531
NickCao merged 4 commits intoNixOS:masterfrom
SuperSandro2000:intel-graphics-compiler-2

Conversation

@SuperSandro2000
Copy link
Member

Description of changes

This also updates the dependencies to the ones used in the release tab of intel-graphics-compiler and spirv-llvm-translator to a newer version which fixed a compile error.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from Ralith and gloaming January 24, 2024 16:27
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 24, 2024
@SuperSandro2000 SuperSandro2000 force-pushed the intel-graphics-compiler-2 branch from 6c3dd04 to eb63875 Compare January 24, 2024 16:31
@SuperSandro2000 SuperSandro2000 changed the title intel-graphics-compiler: 1.0.15136.4 -> 1.0.15610.11 intel-graphics-compiler: 1.0.15136.4 -> 1.0.15610.11 and some of it's direct dependencies Jan 24, 2024
@SuperSandro2000 SuperSandro2000 changed the base branch from master to staging January 24, 2024 16:31
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 24, 2024
@Ralith
Copy link
Contributor

Ralith commented Jan 25, 2024

Weren't spirv-headers and spirv-tools already updated by #281591? We probably shouldn't be updating them separately from the rest of the Vulkan SDK.

@SuperSandro2000
Copy link
Member Author

Then those commits should go away with a rebase.

Keeping them in sync wasn't a concern until now and igc is sometimes very picky about the dependencies used, so if things are older than in there release page, I always updated them in the past.

@SuperSandro2000 SuperSandro2000 force-pushed the intel-graphics-compiler-2 branch from eb63875 to 160bd6c Compare January 27, 2024 17:18
@SuperSandro2000
Copy link
Member Author

Yeah, after a rebase those commits disappeared.

@SuperSandro2000 SuperSandro2000 changed the base branch from staging to master January 27, 2024 17:19
@SuperSandro2000
Copy link
Member Author

@ofborg build intel-graphics-compiler intel-compute-runtime

@NickCao
Copy link
Member

NickCao commented Jan 28, 2024

Result of nixpkgs-review pr 283531 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • rocmPackages.llvm.libclc
  • rocmPackages_5.llvm.libclc
4 packages built:
  • intel-compute-runtime
  • intel-compute-runtime.drivers
  • intel-graphics-compiler
  • opencl-clang

@NickCao NickCao merged commit d0be5a2 into NixOS:master Jan 28, 2024
@SuperSandro2000 SuperSandro2000 deleted the intel-graphics-compiler-2 branch January 28, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants