pcsclite: move binaries, polkit, systemd files to out, move libraries to lib#283452
Merged
NickCao merged 2 commits intoNixOS:stagingfrom Jan 29, 2024
Merged
pcsclite: move binaries, polkit, systemd files to out, move libraries to lib#283452NickCao merged 2 commits intoNixOS:stagingfrom
NickCao merged 2 commits intoNixOS:stagingfrom
Conversation
14ceaba to
ecc103f
Compare
Member
Author
|
I don't think I can test this on my complete nixos config due to the amounts of rebuilds :/ |
Contributor
|
Just tested this and my yubikey works, I believe I did build everything correctly: Merging this should fix #280826 |
NickCao
reviewed
Jan 27, 2024
Member
NickCao
left a comment
There was a problem hiding this comment.
pkgs/development/tools/global-platform-pro/default.nix
1:{ lib, stdenv, fetchFromGitHub, jdk8, maven, makeWrapper, jre8_headless, pcsclite, proot, zlib }:
50: --prefix LD_LIBRARY_PATH : "${pcsclite.out}/lib"
There is another reference require fixing.
… to lib This should make the things related to the udev rules and binaries a lot simpler and more expected.
3125c5f to
38b2b0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This should make the things related to the udev rules and binaries a lot simpler and more expected.
based on feedback in #280826
Closes #280826
Before:
after
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.