Skip to content

python311Packages.monai-deploy: refactor#282821

Merged
fabaff merged 1 commit intoNixOS:masterfrom
fabaff:monai-deploy-fix
Jan 22, 2024
Merged

python311Packages.monai-deploy: refactor#282821
fabaff merged 1 commit intoNixOS:masterfrom
fabaff:monai-deploy-fix

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Jan 22, 2024

Description of changes

Fix build (https://hydra.nixos.org/build/246504367)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff fabaff added the 0.kind: build failure A package fails to build label Jan 22, 2024
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 22, 2024
@fabaff
Copy link
Member Author

fabaff commented Jan 22, 2024

Result of nixpkgs-review pr 282821 run on x86_64-linux 1

4 packages built:
  • python311Packages.monai-deploy
  • python311Packages.monai-deploy.dist
  • python312Packages.monai-deploy
  • python312Packages.monai-deploy.dist

@ofborg ofborg bot requested a review from bcdarwin January 22, 2024 08:32
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 22, 2024
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the fix.

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 22, 2024
@fabaff
Copy link
Member Author

fabaff commented Jan 22, 2024

Result of nixpkgs-review pr 282821 run on aarch64-linux 1

2 packages marked as broken and skipped:
  • python312Packages.monai-deploy
  • python312Packages.monai-deploy.dist
2 packages built:
  • python311Packages.monai-deploy
  • python311Packages.monai-deploy.dist

@fabaff fabaff merged commit a249e81 into NixOS:master Jan 22, 2024
@fabaff fabaff deleted the monai-deploy-fix branch January 22, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: build failure A package fails to build 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants