libjxl: 0.8.2 -> 0.9.1, libaom: remove butteraugli support

[simonhollingshead]

Description of changes

Bumps version of libjxl to 0.9.1. Changes can be seen at https://github.com/libjxl/libjxl/releases.

One of the major changes for 0.9.x is the removal of the butteraugli API.

I have had to remove the option from libaom to use the butteraugli API as a result.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[D4ndellion]

The PR for the removal has some more info: libjxl/libjxl#2576

I don't find it likely libaom will ever enable butteraugli via some other api, and the feature never worked at 10bits which limited its usefulness anyways

[D4ndellion]

buildDocs was added in fefca2f to avoid a circular dependency with libavif -> libaom -> libjxl -> graphviz -> gd -> libavif. Since libaom no longer depends on libjxl this flag can be removed

The override in top-level/all-packages.nix disabling building the docs for the libjxl in libaom also needs to be removed

[D4ndellion]

I built this up to gimp, then successfully opened some jxls.

I also built libaom and did a test encode with aomenc

(on x86_64)

Thanks for your contribution!

[vcunat]

I think this is what broke the build of krita:

/build/krita-5.2.2/plugins/impex/jxl/JPEGXLImport.cpp:514:55: error: cannot convert 'std::nullptr_t' to 'JxlColorProfileTarget'
  514 |                                                       nullptr,
      |                                                       ^~~~~~~
      |                                                       |
      |                                                       std::nullptr_t

https://hydra.nixos.org/build/248773601#tabs-buildsteps

/cc krita maintainers: @abbradar, @sifmelcara, @nek0 and the PR #285983

[sifmelcara]

I think this is what broke the build of krita

Opened #287532