cataclysm-dda: fix gcc 13 build with 3 debian patches.

[detroyejr]

Description of changes

Edit:
Fixed failing gcc 13 build with 3 patches from Debian.

[patch] disable dangling reference warning
[patch] fix build with gcc 13
[patch] cleanup autogenerated prefix.h

Fixed build failures for cataclysm-dda and cataclysm-dda-git by using disable-warnings-if-gcc13 (see #268097).

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[wegank]

Instead of disabling warnings, can we apply patches from Debian or from upstream?

[detroyejr]

Yes, adding 3 patches to pkgs/games/cataclysm-dda/stable.nix fixes the build as well.

Would you mind telling me if fetchpatch is the best way to apply these or if I should use something else?

    patches = [
      # Unconditionally look for translation files in $out/share/locale
      ./locale-path.patch
      (fetchpatch {
        url = "https://sources.debian.org/data/main/c/cataclysm-dda/0.G-4/debian/patches/gcc13-dangling-reference-warning.patch";
        hash = "sha256-9nPbyz49IYBOVHqr7jzCIyS8z/SQgpK4EjEz1fruIPE=";
      })
      (fetchpatch {
        url = "https://sources.debian.org/data/main/c/cataclysm-dda/0.G-4/debian/patches/gcc13-cstdint.patch";
        hash = "sha256-8IBW2OzAHVgEJZoViQ490n37sl31hA55ePuqDL/lil0=";
      })
      (fetchpatch {
        url = "https://sources.debian.org/data/main/c/cataclysm-dda/0.G-4/debian/patches/gcc13-keyword-requires.patch";
        hash = "sha256-8yvHh0YKC7AC/qzia7AZAfMewMC0RiSepMXpOkMXRd8=";
      })
    ];

[wegank]

Would you mind telling me if fetchpatch is the best way to apply these or if I should use something else?

Using fetchpatch is preferred, and your code looks good.

[detroyejr]

Added those 3 patches to the stable.nix and git.nix files in the cataclysm-dda folder. Both build now. Let me know if there's anything else needed.

[DeeUnderscore]

Looks like upstream has these fixed in the master branch as well (independent of the Debian patches):

• CleverRaven/Cataclysm-DDA@9ffcd2b
• CleverRaven/Cataclysm-DDA@99edf38

Haven't checked if they apply cleanly, so the Debian patches might be preferable here. Would be a good idea to include a comment that says something like "Fixes for failing build with GCC13, remove on updating to next release after 0.G"

[DeeUnderscore]

Thanks, looks good, but please squash everything down to one commit with an appropriate commit message.

[detroyejr]

Sounds good. Should be good to go.

[wegank]

@ofborg build cataclysm-dda cataclysm-dda.passthru.tests