[DONTMERGE] simulate ofborg run on #274089#282387
Closed
cole-h wants to merge 4 commits intoNixOS:stagingfrom
Closed
[DONTMERGE] simulate ofborg run on #274089#282387cole-h wants to merge 4 commits intoNixOS:stagingfrom
cole-h wants to merge 4 commits intoNixOS:stagingfrom
Conversation
this uses the value `used-gpr` which seems to be a commonly chosen value for general use
this package set can be used to trial new hardening flags or enable those which are still known to cause some problems
…sm to selectively unsupport zerocallusedregs this allows a compiler derivation to provide a hardeningUnsupportedFlagsByTargetPlatform passthru attr that will be called with the targetPlatform to determine the unsupported hardening flags for that platform. we can do this because even though a clang compiler is multi-target by nature, cc-wrapper effectively fixes the target platform at wrapping time. otherwise we'd have to sniff the intended target at runtime, which wouldn't be fun at all. the advantage of using a new attribute instead of allowing hardeningUnsupportedFlags to optionally be a function is that hardeningUnsupportedFlags retains its simple overriding pattern for simple cases (i.e. `(prev.hardeningUnsupportedFlags or []) ++ [ "foo" ]` ) which will continue to work as long as the bottom-most function of hardeningUnsupportedFlagsByTargetPlatform falls back to hardeningUnsupportedFlags.
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin-stdenv
13 tasks
ofborg
bot
added
10.rebuild-darwin: 501+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Some API weirdness at the time caused ofborg to hit the limit of number of commit statuses on a given SHA and context, which would cause internal errors when GH told it it couldn't set those statuses. Submit this new PR with the same contents to approximate an ofborg run on that PR.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.