Skip to content

python311Packages.primecountpy|pplpy: fix cython_3#282301

Closed
hellwolf wants to merge 0 commit intoNixOS:masterfrom
hellwolf:fix-primecountpy-cython_3
Closed

python311Packages.primecountpy|pplpy: fix cython_3#282301
hellwolf wants to merge 0 commit intoNixOS:masterfrom
hellwolf:fix-primecountpy-cython_3

Conversation

@hellwolf
Copy link
Copy Markdown
Contributor

@hellwolf hellwolf commented Jan 20, 2024

Description of changes

Fix #282082, following conversation from https://matrix.to/#/!VjfUzaKsXokUdnQcvP:nixos.org/$lSZueVjCGihCYMmaRrcYO8umJUveF_BjOHK55FZSd8s?via=nixos.org&via=matrix.org&via=envs.net

Also discovered that "pplpy" can benefit from the same fix.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 20, 2024
@hellwolf
Copy link
Copy Markdown
Contributor Author

@ofborg build python311Packages.primecountpy

@hellwolf hellwolf marked this pull request as ready for review January 20, 2024 10:38
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 20, 2024
@hellwolf hellwolf changed the title python311Packages.primecountpy: fix cython_3 python311Packages.primecountpy|pplpy|cypari2: fix cython_3 Jan 20, 2024
@hellwolf hellwolf changed the title python311Packages.primecountpy|pplpy|cypari2: fix cython_3 python311Packages.primecountpy|pplpy: fix cython_3 Jan 20, 2024
@hellwolf
Copy link
Copy Markdown
Contributor Author

@ofborg build python311Packages.primecountpy python311Packages.pplpy python312Packages.primecountpy python312Packages.pplpy

@hellwolf hellwolf marked this pull request as draft January 20, 2024 11:41
@hellwolf
Copy link
Copy Markdown
Contributor Author

hellwolf commented Jan 20, 2024

python311Packages.cypari2 still fails to build:

error: builder for '/nix/store/smr35vvqlbm2d6x7pc2plmr35mfcrzc4-python3.11-cypari2-2.1.3.drv' failed with exit code 1;
       last 10 log lines:
       >     cmd_obj.run()
       >   File "setup.py", line 46, in run
       >     self.distribution.ext_modules[:] = cythonize(
       >                                        ^^^^^^^^^^
       >   File "/nix/store/xx59gyk65a4s5vrmql8dyddx69dbvwfi-python3.11-cython-3.0.6/lib/python3.11/site-packages/Cython/Build/Dependencies.py", line 1154, in cythonize
       >     cythonize_one(*args)
       >   File "/nix/store/xx59gyk65a4s5vrmql8dyddx69dbvwfi-python3.11-cython-3.0.6/lib/python3.11/site-packages/Cython/Build/Dependencies.py", line 1321, in cythonize_one
       >     raise CompileError(None, pyx_file)
       > Cython.Compiler.Errors.CompileError: cypari2/handle_error.pyx
       > /nix/store/v5irq7wvkr7kih0hhnch5nnv2dcq8c4f-stdenv-linux/setup: line 1557: pop_var_context: head of shell_variables not a function context
       For full logs, run 'nix log /nix/store/smr35vvqlbm2d6x7pc2plmr35mfcrzc4-python3.11-cypari2-2.1.3.drv'.
error: 1 dependencies of derivation '/nix/store/clvh0lb18jwlpx1ifsgvipyayhmk6p9j-python3.11-sagelib-10.0.drv' failed to build
error: 2 dependencies of derivation '/nix/store/88c955flj6rfqkvfx4rin6vj0f1n1qaz-python3-3.11.7-env.drv' failed to build
error: 2 dependencies of derivation '/nix/store/alba95356hxly0j7ablyychpjsply8j3-sage-env.drv' failed to build
error: 2 dependencies of derivation '/nix/store/86jhyl4kx1hd1qv8mjxc5ky8w08p2hka-sage-with-env-10.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/zkv5y1ipcffdw4y2xrrqpygmgjabcpjv-jupyter-kernels.drv' failed to build
error: 1 dependencies of derivation '/nix/store/aa398vvx8kmy6vh7qmrahpwwjh7ak8m7-sage-tests-10.0.drv' failed to build
error: 3 dependencies of derivation '/nix/store/kardb2s19vjm62hd0dl4c7drzx95z0x1-sage-10.0.drv' failed to build
error: 2 dependencies of derivation '/nix/store/2ylkrvq00yzyij22msg8jpbmx80sw2b7-sagedoc-10.0.drv' failed to build
error: 4 dependencies of derivation '/nix/store/h54qlyqy696v15sby3c70s8gxsz4q4b7-sage-10.0.drv' failed to build
error: interrupted by the user
$ git worktree remove -f /home/hellwolf/.cache/nixpkgs-review/pr-282301-3/nixpkgs

@collares
Copy link
Copy Markdown
Member

#281579 fixes the cypari2 problem, but doesn't fix sage. Do you use cypari2 by itself? If so, I can merge that PR. Otherwise I'd rather wait for the Sage upgrade PR which I'm currently preparing.

@collares
Copy link
Copy Markdown
Member

Ah, okay, you use primecountpy. I will merge the other PR then.

@collares
Copy link
Copy Markdown
Member

Apologies for not migrating to cython_3 at this moment. I will do it once Sage is upgraded. The reason is that, while some Sage 10.0 tests fail, at leaat it builds with the old cython. Sage 10.2 will budild with Python 3.

@hellwolf
Copy link
Copy Markdown
Contributor Author

ah, actually I am here because of sage

@hellwolf hellwolf force-pushed the fix-primecountpy-cython_3 branch from 193344a to 4af8ab3 Compare January 20, 2024 16:33
@hellwolf hellwolf closed this Jan 20, 2024
@hellwolf hellwolf force-pushed the fix-primecountpy-cython_3 branch from 4af8ab3 to f1557a2 Compare January 20, 2024 17:05
@hellwolf hellwolf deleted the fix-primecountpy-cython_3 branch January 20, 2024 17:05
@hellwolf
Copy link
Copy Markdown
Contributor Author

#281579 fixes the cypari2 problem, but doesn't fix sage. Do you use cypari2 by itself? If so, I can merge that PR. Otherwise I'd rather wait for the Sage upgrade PR which I'm currently preparing.

Btw, is there such sage upgrade on going? Currently sage package is broken.

@collares
Copy link
Copy Markdown
Member

@hellwolf That's #283322 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: python311Packages.primecountpy

2 participants