Skip to content

wireguard-vanity-keygen: init at 0.0.7#282164

Merged
h7x4 merged 1 commit intoNixOS:masterfrom
arikgrahl:wireguard-vanity-keygen
Jan 21, 2024
Merged

wireguard-vanity-keygen: init at 0.0.7#282164
h7x4 merged 1 commit intoNixOS:masterfrom
arikgrahl:wireguard-vanity-keygen

Conversation

@arikgrahl
Copy link
Contributor

Description of changes

A WireGuard vanity key generator, which has a richer feature set than wireguard-vanity-address, which is already present in nixpkgs.
The project's website is https://github.com/axllent/wireguard-vanity-keygen

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 19, 2024
@infinisil
Copy link
Member

Congrats, you're the first victim of #275539! 🎉

@arikgrahl arikgrahl force-pushed the wireguard-vanity-keygen branch from 5b72bf4 to aef9f06 Compare January 19, 2024 23:40
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 20, 2024
@sikmir
Copy link
Member

sikmir commented Jan 20, 2024

Result of nixpkgs-review pr 282164 run on x86_64-darwin 1

1 package built:
  • wireguard-vanity-keygen

@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 20, 2024
@h7x4
Copy link
Member

h7x4 commented Jan 20, 2024

Would you mind squashing the fixups into wireguard-vanity-address: init at 0.7.0?

@arikgrahl arikgrahl force-pushed the wireguard-vanity-keygen branch from 439c136 to 42229a9 Compare January 20, 2024 20:32
@arikgrahl
Copy link
Contributor Author

@h7x4, sure! i have just squashed them accordingly.

@h7x4
Copy link
Member

h7x4 commented Jan 20, 2024

The version in the commit message seems wrong. I think it should be 0.0.7

@delroth delroth added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jan 20, 2024
@drupol
Copy link
Contributor

drupol commented Jan 21, 2024

The title and the description of this PR doesn't correspond to the changes.

The changes are about wireguard-vanity-keygen while the PR title is about wireguard-vanity-address.

@arikgrahl arikgrahl force-pushed the wireguard-vanity-keygen branch from 42229a9 to 8c411cb Compare January 21, 2024 21:40
@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jan 21, 2024
@arikgrahl arikgrahl changed the title wireguard-vanity-address: init at 0.7.0 wireguard-vanity-address: init at 0.0.7 Jan 21, 2024
@arikgrahl arikgrahl changed the title wireguard-vanity-address: init at 0.0.7 wireguard-vanity-keygen: init at 0.0.7 Jan 21, 2024
@arikgrahl arikgrahl force-pushed the wireguard-vanity-keygen branch from 8c411cb to d1be19d Compare January 21, 2024 22:14
@delroth delroth added the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Jan 21, 2024
@h7x4 h7x4 merged commit 7c6550f into NixOS:master Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants