Revert "python3Packages.rasterio: 1.3.9 -> 4"

[imincik]

Description of changes

rasterio version 4 doesn't exist. Package is failing to build with
this change.

release-test-4 version is some 9 years old branch !

This change was merged as part of #271586 in ee7f056 .

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[imincik]

I would be very happy to have some explanation from @mweinelt . I can't imagine the reason of making such change.

[kirillrdy]

i assume that was automated, we should run ./maintainers/scripts/update-python-libraries and see if it updates it again, if so then we should add passthru.skipBulkUpdate = true

[imincik]

I confirm running

$ ./maintainers/scripts/update-python-libraries pkgs/development/python-modules/rasterio/default.nix

INFO:root:Updating packages...
INFO:root:Path /home/imincik/Projects/nix/nixpkgs/code/pkgs/development/python-modules/rasterio/default.nix: updated rasterio from 1.3.9 to 4
INFO:root:Finished updating packages.
INFO:root:1 package(s) updated

caused the change.

I don't want to add passthru.skipBulkUpdate = true to all packages which I maintain. I would be happier if such bulk changes would be properly reviewed by package maintainers. I haven't seen any review notification for this.

[kirillrdy]

I confirm running

$ ./maintainers/scripts/update-python-libraries pkgs/development/python-modules/rasterio/default.nix

INFO:root:Updating packages...
INFO:root:Path /home/imincik/Projects/nix/nixpkgs/code/pkgs/development/python-modules/rasterio/default.nix: updated rasterio from 1.3.9 to 4
INFO:root:Finished updating packages.
INFO:root:1 package(s) updated

caused the change.

I don't want to add passthru.skipBulkUpdate = true to all packages which I maintain. I would be happier if such bulk changes would be properly reviewed by package maintainers. I haven't seen any review notification for this.

thats very good point, maybe we can fix updater to prevent upgrades to tag that has earlier created date ?

[imincik]

maybe we can fix updater to prevent upgrades to tag that has earlier created date ?

Yes, this can help, but still, I think the review is a must.

[kirillrdy]

yes sorry I didn't reply to "review" portion of your comment.

maybe @mweinelt can answer how python-updates PR notify people.

as for this PR, without passthru.skipBulkUpdate = true update will happen again.

you can disable bulk updates and rely on ryan bot, or manually updating package, but I am hoping we can resolve it by then

[dotlambda]

we should add passthru.skipBulkUpdate = true

Why was this not done??

[imincik]

we should add passthru.skipBulkUpdate = true

Why was this not done??

I hope in fix in update-python-libraries.py rather then adding this in packages because of update script bugs. But I am of course happy to add it if update script can't/wouldn't be fixed.

[SuperSandro2000]

I am not sure if that can be fixed in the update script without reducing it's reliability with repos that do not always create releases.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team/37035/6