corrscope: relax ruamel.yaml dependency; fix build#281622
Merged
1 commit merged intomasterfrom Jan 25, 2024
unknown repository
Merged
corrscope: relax ruamel.yaml dependency; fix build#2816221 commit merged intomasterfrom unknown repository
1 commit merged intomasterfrom
unknown repository
Conversation
Member
2 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
Author
|
ping @OPNA2608 |
OPNA2608
approved these changes
Jan 25, 2024
Contributor
OPNA2608
left a comment
OPNA2608
left a comment
There was a problem hiding this comment.
Sorry! Went under in my mailbox. 😓
Result of nixpkgs-review pr 281622 run on x86_64-linux 1
2 packages built:
- corrscope
- corrscope.dist
Builds & launches fine, looks sensible, opening & saving YAML configurations works. LGTM.
delroth
added
the
12.approvals: 1
OPNA2608
added
the
12.approved-by: package-maintainer
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://hydra.nixos.org/build/246422133
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.