Skip to content

Comments

chromaprint: build with ffmpeg_6#281595

Merged
NickCao merged 1 commit intoNixOS:stagingfrom
NickCao:chromaprint
Feb 9, 2024
Merged

chromaprint: build with ffmpeg_6#281595
NickCao merged 1 commit intoNixOS:stagingfrom
NickCao:chromaprint

Conversation

@NickCao
Copy link
Member

@NickCao NickCao commented Jan 17, 2024

Description of changes

The patches picked are aligned with Arch Linux: https://gitlab.archlinux.org/archlinux/packaging/packages/chromaprint/-/tree/main

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NickCao NickCao changed the base branch from master to staging January 17, 2024 18:48
@ofborg ofborg bot requested a review from a user January 29, 2024 01:34
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 29, 2024
@NickCao
Copy link
Member Author

NickCao commented Jan 30, 2024

ping the maintainers of the major reverse dependency gst_all_1.gst-plugins-bad

@NickCao NickCao requested a review from alyssais February 8, 2024 19:03
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@NickCao NickCao merged commit d209d34 into NixOS:staging Feb 9, 2024
@NickCao NickCao deleted the chromaprint branch February 9, 2024 15:10
@emilazy emilazy mentioned this pull request Aug 2, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants