Conversation
|
Tested basic functionality: it listens for keypresses when osu-lazer is in focus and updates the key counter accordingly on X11. Thanks for packaging it @TomaSajt! |
27f0d67 to
afb47ec
Compare
afb47ec to
e2cd418
Compare
|
Thank you for your work! Some suggestions:
|
cfcbb87 to
77cf6f7
Compare
|
I did a big restructuring of the whole derivation, hopefully this way its in a more "override"-able state. I also dropped the usage of |
|
I can't seem to be able to use the colors set in the color selector (bug?), so I don't know if the transparency fix works or not. |
In the color config interface, there is a checkbox saying "enable custom colors". You need check that on. Upon second thought, I think enabling this flag in the command wrapper may cause some problems when OpenGL is not supported? I do not have an environment to test that, though. |
I'm using a dark theme, so most of the UI is pretty unintelligible, because of this that toggle button wasn't even visible to me. I tried it out, and it wasn't working properly yet. However after debugging with |
193fc25 to
4a117bf
Compare
Cool! Do you think this can be generalized and used across nixpkgs? |
I think we can, but mostly with manual patches. |
9ebd384 to
3a879c8
Compare
|
#272380 got merged, so you should adjust the code accordingly (it should be greatly simplified). See https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/gradle.section.md |
That's really great to hear, I've been excited to finally try it out. |
9c47a80 to
76ef523
Compare
Description of changes
Closes #281453
This PR adds 1 package:
keyspersecondThis is a java app, using Gradle as the build system.
Luckily, there were less gradle shenanigans than with other packages.
I used
stripJavaArchivesHookto fix the timestamps in the jar fileI do not know if darwin also needs extra runtime libraries, sadly I cannot test it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.