Merged
Conversation
github-actions
bot
added
the
8.has: documentation
DanielSidhion
approved these changes
Jan 15, 2024
Member
DanielSidhion
left a comment
DanielSidhion
left a comment
There was a problem hiding this comment.
Perhaps it would be useful to mention the names from https://nixos.org/manual/nix/stable/language/values (or some other resource), just to try to get people use the same names, e.g. "Attribute set" instead of "Attrset" (or something else).
This is optional though, because imo it's more important to have some type even if not consistent throughout the docs (which we can be fixed later, especially because the definition list format is already well-defined).
Contributor
Author
|
Good point, added a reference to types. |
DanielSidhion
approved these changes
Jan 15, 2024
DanielSidhion
added
the
12.approvals: 1
ofborg
bot
added
10.rebuild-darwin: 0
Co-authored-by: Daniel Sidhion <DanielSidhion@users.noreply.github.com>
delroth
removed
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-01-25-documentation-team-meeting-notes-106/38792/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@DanielSidhion here's a proposal, following up on #281211 (comment)
Add a 👍 reaction to pull requests you find important.