poetry: Relax dep requirement check for xattr#281103
Merged
dotlambda merged 1 commit intoNixOS:masterfrom Jan 15, 2024
Merged
Conversation
Following from NixOS#280522, the xattr dependency still failed the pythonRuntimeDepsCheck hook, likely overlooked because it is a Darwin-only dep: > Checking runtime dependencies for poetry-1.7.1-py3-none-any.whl > - xattr<0.11.0,>=0.10.0 not satisfied by version 1.0.0 From 0.10.0 to 1.0.0 there are no functional changes with compatibility implications, only dropped support for Python 2.
NixOSInfra
added
the
12.first-time contribution
ofborg
bot
added
10.rebuild-darwin: 1-10
evalexpr
approved these changes
Jan 15, 2024
delroth
added
the
12.approvals: 1
dotlambda
approved these changes
Jan 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following from #280522, the xattr dependency still failed the pythonRuntimeDepsCheck hook, likely overlooked because it is a Darwin-only dep:
From 0.10.0 to 1.0.0 there are no functional changes with compatibility implications, only dropped support for Python 2.
Description of changes
fixes #281184
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.